[6.x] Prevent reordering from showing a false badge on the filter button - #15079
Merged
jasonvarga merged 3 commits intoAug 7, 2026
Merged
Conversation
lazerg
force-pushed
the
fix/issue-15078-reorder-filter-badge
branch
from
July 26, 2026 01:47
3845214 to
819df85
Compare
Contributor
Author
|
Hey @jasonvarga, please check this when you have time. |
Member
|
Sorry, we can't provide an ETA for reviewing/merging this pull request. 😞 It's already on our to-do list and we'll review it when we can. If you need to use this fix in the meantime, consider applying this PR as a composer patch. |
Removes allowPresets/allowBulkActions/allowCustomizingColumns, which have no effect since the default slot override already suppresses that part of the template. mountListing now takes a props object instead of a positional filters arg. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reordering entries in a collection with a max depth of one puts a "1" badge on the Filters button, even though nothing is filtered and the Filters panel has nothing to clear. Reordering adds an internal site filter to scope the query, and the badge count was counting every active filter badge the server returned, that internal one included. Now the count only covers badges whose handles belong to the listing's configured filters, which is what the Filters panel already shows.
Fixes #15078
Screen.Recording.2026-07-26.at.06.41.45.mp4